-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Documentation Audit changes #1008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Destruccuting props as args in functional component signatures allows storybook to infer default values of props
- Migration from addon-info to addon-docs involves parameter changes for component descriptions included in this commit
brandonlenz
changed the title
[WIP] docs: Documentation Audit changes
docs: Documentation Audit changes
Mar 10, 2021
brandonlenz
requested review from
ahobson,
gidjin,
haworku,
sarboc,
SirenaBorracha,
suzubara and
tinyels
as code owners
March 10, 2021 20:08
suzubara
previously approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!! Thanks for taking on all this work 🎉
suzubara
approved these changes
Mar 16, 2021
This was referenced Mar 17, 2021
Merged
brandonlenz
added a commit
that referenced
this pull request
May 12, 2021
* Link to README * Link to license * Add FAQ about where to file issues * Update Icon documentation * Allow storybook to infer prop defaults - Destructuring props as args in functional component signatures allows storybook to infer default values of props * Show storybook descriptions on docs page - Migration from addon-info to addon-docs involves parameter changes for component descriptions included in this commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was recently recommended to do an audit of our documentation. This PR includes the changes I recommend.
Additionally, we migrated from the now-deprecated storybook
addon-info
toaddon-docs
, however the parameters api for attaching component descriptions to storybook changed. This PR updates our stories to display the brief descriptions and, more importantly, source links to the original uswds components. ed171f9 For example:Finally, while looking through storybook I was reminded that the documentation around our component props does not populate default values for optional props. This is solved by doing prop restructuring in the functional component signature rather than in the method body. 27f16c2 For example:
Instead of:
yielding:
How To Test